Hi, As I stated in the comment below I'm a bit hesitant to add db specifics to the ConnectionFactory, but I don't see another easy way to address the postgres issue except for removing the "ds.setValidationQueryTimeout(3);" line completely. For trunk we might take a route to get the settings from a configuration file instead of hardcoding them, but for the 2.4 branch that is probably a bit too drastic.
Any thoughts? Bart On Mon, Nov 19, 2012 at 12:20 PM, Bart van der Schans (JIRA) < j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/JCR-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500154#comment-13500154] > > Bart van der Schans commented on JCR-3445: > ------------------------------------------ > > Hi Luca, > > Thanks for explaining and the patch. I'm a bit hesitant to add db/postgres > specific logic to the ConnectionFactory class. Does anybody know a way to > detect support for the method on runtime? > > Bart > > > PostgreSQL error with setValidationQueryTimeout > > ----------------------------------------------- > > > > Key: JCR-3445 > > URL: https://issues.apache.org/jira/browse/JCR-3445 > > Project: Jackrabbit Content Repository > > Issue Type: Bug > > Components: jackrabbit-core > > Affects Versions: 2.4.3, 2.5.2 > > Environment: Linux Ubuntu 10.04 server with PostgreSQL 9.1 > remote DB > > Reporter: Luca Tagliani > > Assignee: Bart van der Schans > > Priority: Critical > > Fix For: 2.4.4, 2.5.3 > > > > Attachments: catalina.out, JCR-3445-1.patch, JCR-3445.patch, > repositorySimple.xml > > > > > > In this version inside o.a.j.c.util.db.ConnectionFactory class, it's > been added a validationQueryTimeout (line 344). > > The problem is that the use of queryTimeout is not implemented in any > PostgreSQL jdbc driver (see http://jdbc.postgresql.org/todo.htmlCompliance > section) > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira > -- Amsterdam - Oosteinde 11, 1017 WT Amsterdam Boston - 1 Broadway, Cambridge, MA 02142 US +1 877 414 4776 (toll free) Europe +31(0)20 522 4466 www.onehippo.com
