[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620727#comment-13620727
]
Michael Dürig commented on JCR-3555:
------------------------------------
+1 for IllegalStateException instead of RuntimeException as in revision 1463860
+1 for a marker interface (i.e. OneShotIterable) such that clients can find out
about the specific behaviour not just after the fact.
> Add a static utility to transform JCR Iterators into Iterables
> --------------------------------------------------------------
>
> Key: JCR-3555
> URL: https://issues.apache.org/jira/browse/JCR-3555
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
> Affects Versions: 2.6
> Reporter: Lukas Eder
> Priority: Minor
> Attachments: Iterators.java.patch
>
>
> I have stumbled upon the utility classes in the
> org.apache.jackrabbit.commons.iterator package. They're quite useful in
> principle, but not applied thoroughly. E.g. there are missing wrapper types
> for at least these JCR Iterators:
> - AccessControlPolicyIterator
> - EventIterator
> - EventListenerIterator
> - NodeTypeIterator
> - VersionIterator
> Instead of adding more classes, it might be useful to create static methods
> for the job. Using static methods from a single class (with static imports)
> is a bit more convenient than looking up and creating the wrapper types using
> "new WrapperType(...)"
> An example:
> org.apache.jackrabbit.commons.iterator.Iterators.iterable
> // And then:
> for (Node n : iterable(parent.getNodes())) {
> // Do stuff with n
> }
> Please find attached a .patch file containing an implementation suggestion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
