[
https://issues.apache.org/jira/browse/JCR-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648576#comment-13648576
]
Alexander Klimetschek commented on JCR-3534:
--------------------------------------------
HMAC stuff is good afaics (not an expert), but some things are missing:
- it's on the Binary level and not on the more generic Value level (but ok for
me)
- instead of resolving the message upon writing to the repository, it is
instead written as Binary (with the message as contents)
- but it's never resolved to the final binary that you want (if the message is
valid)
- the public API is still missing (BinaryReferenceMessage is in a jackrabbit
internal package); I think a public api Binary getBinaryBySecureID() (or
similar) like in the first patch is still required
- and then you'd write the returned Binary right to the repository (no delayed
resolution)
- this is important, since the application level code needs to know if that
getBinaryBySecureID() worked or not (returns non-null or not) so it can handle
the case by asking for the full binary as stream over its own message protocol
- btw, some lucene-related java files are accidentally included in the patch
with import reorgs
> Add JackrabbitSession.getValueByContentId method
> ------------------------------------------------
>
> Key: JCR-3534
> URL: https://issues.apache.org/jira/browse/JCR-3534
> Project: Jackrabbit Content Repository
> Issue Type: New Feature
> Components: jackrabbit-api, jackrabbit-core
> Affects Versions: 2.6
> Reporter: Felix Meschberger
> Assignee: Tommaso Teofili
> Attachments: JCR-3534.patch, JCR-3534.patch
>
>
> we have a couple of use cases, where we would like to leverage the global
> data store to prevent sending around and copying around large binary data
> unnecessarily: We have two separate Jackrabbit instances configured to use
> the same DataStore (for the sake of this discussion assume we have the
> problems of concurrent access and garbage collection under control). When
> sending content from one instance to the other instance we don't want to send
> potentially large binary data (e.g. video files) if not needed.
> The idea is for the sender to just send the content identity from
> JackrabbitValue.getContentIdentity(). The receiver would then check whether
> the such content already exists and would reuse if so:
> String ci = contentIdentity_from_sender;
> try {
> Value v = session.getValueByContentIdentity(ci);
> Property p = targetNode.setProperty(propName, v);
> } catch (ItemNotFoundException ie) {
> // unknown or invalid content Identity
> } catch (RepositoryException re) {
> // some other exception
> }
> Thus the proposed JackrabbitSession.getValueByContentIdentity(String) method
> would allow for round tripping the JackrabbitValue.getContentIdentity()
> preventing superfluous binary data copying and moving.
> See also the dev@ thread
> http://jackrabbit.markmail.org/thread/gedk5jsrp6offkhi
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
