[ 
https://issues.apache.org/jira/browse/JCR-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649858#comment-13649858
 ] 

Tommaso Teofili commented on JCR-3534:
--------------------------------------

@Alexander I think we cannot store the real binary in the referenced binary, 
otherwise what's the matter of sending the reference message? It'd still hold 
the binary data so there wouldn't be any reason for doing any check, just re 
import the binary and that's it.

Earlier we agreed we don't want public API for this, now we want a public API 
again, but this scenario shouldn't apply to generic binary handling, just to 
the case where the datastore is shared so I don't think this would trigger any 
code rewrite.

In the end: do we want to design this scenario by giving an API? If yes then 
probably Alex's concern makes sense, if not then it's just another Binary 
implementation which can be created from a "master" repository to avoid sending 
the actual binary, then the "slave" repository checks if he has such a binary 
with the given approach (by accessing the data store), if not (or if it's been 
changed) the "master" will send again the same node with the actual binary 
instead of the reference binary and the "slave" will import it now with the 
proper actual binary.

Any other opinions?

                
> Efficient copying of binaries across repositories with the same data store
> --------------------------------------------------------------------------
>
>                 Key: JCR-3534
>                 URL: https://issues.apache.org/jira/browse/JCR-3534
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-api, jackrabbit-core
>    Affects Versions: 2.6
>            Reporter: Felix Meschberger
>            Assignee: Tommaso Teofili
>         Attachments: JCR-3534.2.patch, JCR-3534.patch, JCR-3534.patch
>
>
> we have a couple of use cases, where we would like to leverage the global 
> data store to prevent sending around and copying around large binary data 
> unnecessarily: We have two separate Jackrabbit instances configured to use 
> the same DataStore (for the sake of this discussion assume we have the 
> problems of concurrent access and garbage collection under control). When 
> sending content from one instance to the other instance we don't want to send 
> potentially large binary data (e.g. video files) if not needed.
> The idea is for the sender to just send the content identity from 
> JackrabbitValue.getContentIdentity(). The receiver would then check whether 
> the such content already exists and would reuse if so:
> String ci = contentIdentity_from_sender;
> try {
>     Value v = session.getValueByContentIdentity(ci);
>     Property p = targetNode.setProperty(propName, v);
> } catch (ItemNotFoundException ie) {
>     // unknown or invalid content Identity
> } catch (RepositoryException re) {
>     // some other exception
> }
> Thus the proposed JackrabbitSession.getValueByContentIdentity(String) method 
> would allow for round tripping the JackrabbitValue.getContentIdentity() 
> preventing superfluous binary data copying and moving. 
> See also the dev@ thread 
> http://jackrabbit.markmail.org/thread/gedk5jsrp6offkhi

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to