[
https://issues.apache.org/jira/browse/JCR-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871926#comment-13871926
]
Thomas Mueller commented on JCR-3705:
-------------------------------------
[~ajain], I think there is a problem with the patch. It contains duplicated
changes (for example, the class
jackrabbit-data/src/main/java/org/apache/jackrabbit/data/cache/Backend.java is
added multiple times). More problematic, there seem to be line break changes
(jackrabbit-aws-ext/src/main/java/org/apache/jackrabbit/aws/ext/ds/S3Backend.java
for example) where all lines of a class are removed but then added back. I
guess the patch file was created by a tool you used, but to verify the patch it
would be nice to have a "small" patch. Would it be possible for you to shrink
the patch (remove duplications, not change line break style)?
> Extract data store API and implementations from jackrabbit-core
> ---------------------------------------------------------------
>
> Key: JCR-3705
> URL: https://issues.apache.org/jira/browse/JCR-3705
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Jukka Zitting
> Labels: patch
> Attachments: JCR-3705.patch
>
>
> In Oak we'd like to use the Jackrabbit data stores (OAK-805). Doing so would
> currently require a direct dependency to jackrabbit-core, which is
> troublesome for various reasons.
> Since the DataStore interface and its implementations are mostly independent
> of the rest of Jackrabbit internals, it should be possible to avoid that
> dependency by moving the data store bits to some other component.
> One alternative would be to place them in jackrabbit-jcr-commons, another to
> create a separate new jackrabbit-data component for this purpose. WDYT?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
