[ 
https://issues.apache.org/jira/browse/JCR-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910370#comment-13910370
 ] 

Jukka Zitting commented on JCR-3735:
------------------------------------

bq. This step is an additional overhead when the upload process itself creates 
a temporary file.

IMHO the additional overhead is the temporary file created by the upload 
process before passing the incoming stream to the DataStore.

bq. use the FileChannel object associated with the input stream to copy the file

We can do that, but the gains will be much smaller than if we could avoid the 
temporary file entirely.

> Efficient copying of binaries in Jackrabbit DataStores
> ------------------------------------------------------
>
>                 Key: JCR-3735
>                 URL: https://issues.apache.org/jira/browse/JCR-3735
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.7.4
>            Reporter: Amit Jain
>
> In the DataStore implementations an additional temporary file is created for 
> every binary uploaded. This step is an additional overhead when the upload 
> process itself creates a temporary file. 
> So, the solution proposed is to check if the input stream passed is a 
> FileInputStream and then use the FileChannel object associated with the input 
> stream to copy the file.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to