[
https://issues.apache.org/jira/browse/JCRVLT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646859#comment-14646859
]
Tobias Bocanegra edited comment on JCRVLT-97 at 7/29/15 10:31 PM:
------------------------------------------------------------------
(sorry for the late) comments to the patch:
- instead of tweaking how to select the default aggregator in
{{org.apache.jackrabbit.vault.fs.impl.AggregateManagerImpl#getAggregator}} - I
would rather just have a different config for the binary less case, and remove
the file aggregator:
https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-core/src/main/resources/org/apache/jackrabbit/vault/fs/config/defaultConfig-1.1.xml#L26
- instead of adding the flag {{NAME_USE_BINARY_REFERENCES}} to the package
properties, I would add it to the fs config as well. since it is a attribute of
the aggregation, not directly related to packaging. but lets keep it there for
easier configuration of the package.
I created a proposal:
https://github.com/apache/jackrabbit-filevault/compare/trunk...tripodsan:JCRVLT-97
was (Author: tripod):
(sorry for the late) comments to the patch:
- instead of tweaking how to select the default aggregator in
{{org.apache.jackrabbit.vault.fs.impl.AggregateManagerImpl#getAggregator}} - I
would rather just have a different config for the binary less case, and remove
the file aggregator:
https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-core/src/main/resources/org/apache/jackrabbit/vault/fs/config/defaultConfig-1.1.xml#L26
- instead of adding the flag {{NAME_USE_BINARY_REFERENCES}} to the package
properties, I would add it to the fs config as well. since it is a attribute of
the aggregation, not directly related to packaging.
I created a proposal:
https://github.com/apache/jackrabbit-filevault/compare/trunk...tripodsan:JCRVLT-97
> Implement binaryless export
> ---------------------------
>
> Key: JCRVLT-97
> URL: https://issues.apache.org/jira/browse/JCRVLT-97
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Reporter: Marius Petria
> Attachments: JCRVLT-97.1.patch, JCRVLT-97.2.patch, JCRVLT-97.patch
>
>
> In order to efficiently transport content between instances that share the
> same data store packaging could support a binaryless mode, i.e. instead of
> packaging the actual binaries it should package only the references to those
> binaries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
