[
https://issues.apache.org/jira/browse/JCRVLT-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petria updated JCRVLT-106:
---------------------------------
Description:
Importing an user and children with UPDATE mode causes unnecessary warnings.
Assume a package with a {{testuser}} and a child node {{profile}}. Installing
the package twice with {{UPDATE}} mode will trigger some warnings at the second
install.
{noformat}
org.apache.jackrabbit.vault.fs.impl.io.JcrSysViewTransformer Unable to move
child back to new location
{noformat}
That happens because the profile node is saved in a temporary location but when
it needs to be restored [1] (or [2] in trunk) the move fails because profile
node already exists under the newly recreated user. We could mitigate the
unnecessary warning by first checking if the child node already exists before
trying a move.
[1]
https://github.com/apache/jackrabbit-filevault/blob/95e769cefce3199e7351118129d3358828f206d8/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/JcrSysViewTransformer.java#L138
[2]
https://github.com/apache/jackrabbit-filevault/blob/944fdcb23fc6707d1dd844586a2abbb26ca30d49/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/ChildNodeStash.java#L130
was:
Importing an user and children with UPDATE mode causes unnecessary warnings.
Assume a package with a {{testuser}} and a child node {{profile}}. Installing
the package twice with {{UPDATE}} mode will trigger some warnings at the second
install.
{noformat}
org.apache.jackrabbit.vault.fs.impl.io.JcrSysViewTransformer Unable to move
child back to new location
{noformat}
That happens because the profile node is saved in a temporary location but when
it needs to be restored [1] the move fails because profile node already exists
under the newly recreated user. We could mitigate the unnecessary warning by
first checking if the child node already exists before trying a move.
[1]
https://github.com/apache/jackrabbit-filevault/blob/95e769cefce3199e7351118129d3358828f206d8/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/JcrSysViewTransformer.java#L138
> Importing an user and children with UPDATE mode causes unnecessary warnings
> ---------------------------------------------------------------------------
>
> Key: JCRVLT-106
> URL: https://issues.apache.org/jira/browse/JCRVLT-106
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Affects Versions: 3.1.24
> Reporter: Marius Petria
> Priority: Minor
>
> Importing an user and children with UPDATE mode causes unnecessary warnings.
> Assume a package with a {{testuser}} and a child node {{profile}}. Installing
> the package twice with {{UPDATE}} mode will trigger some warnings at the
> second install.
> {noformat}
> org.apache.jackrabbit.vault.fs.impl.io.JcrSysViewTransformer Unable to move
> child back to new location
> {noformat}
> That happens because the profile node is saved in a temporary location but
> when it needs to be restored [1] (or [2] in trunk) the move fails because
> profile node already exists under the newly recreated user. We could mitigate
> the unnecessary warning by first checking if the child node already exists
> before trying a move.
> [1]
> https://github.com/apache/jackrabbit-filevault/blob/95e769cefce3199e7351118129d3358828f206d8/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/JcrSysViewTransformer.java#L138
> [2]
> https://github.com/apache/jackrabbit-filevault/blob/944fdcb23fc6707d1dd844586a2abbb26ca30d49/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/ChildNodeStash.java#L130
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
