[ 
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208988#comment-16208988
 ] 

Tobias Bocanegra commented on JCRVLT-210:
-----------------------------------------

thanks for the patch. I will merge it in shortly. I think the .DS_Store, 
.gitignore, .svn should also go in the default excludes

also, I think the {{builtContentDirectory}} is a legacy name that stipulates 
that the content directory is 'built'. how about adding:

- *{{jcrRootDirectory}}* defaults to builtContentDirectory/jcr_root
- *{{vaultMetaDirectoy}}* defaults to builtContentDirectory/META-INF/vault

or just:

- *{{packageSource}}* defaults to builtContentDirectory

and deprecate the {{builtContentDirectory}} ?


> Allow to define excludes for the ContentPackageArchiver to prevent copying of 
> script files from src to target
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-210
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-210
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>            Reporter: Konrad Windszus
>            Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion 
> filename patterns of files which should never end up in the filevault package 
> (compare with 
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter 
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by 
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source 
> directory without being forced to first use the {{maven-resource-plugin}} to 
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}} 
> could be modified to point to the source directory e.g. 
> {{${basedir}/src/main/jcr_root}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to