[
https://issues.apache.org/jira/browse/JCRVLT-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519343#comment-16519343
]
Marius Petria edited comment on JCRVLT-305 at 6/21/18 1:07 PM:
---------------------------------------------------------------
[~tripod] thanks for the fix. Just a clarifying question. It looks that
patterns only apply to subnodes of the root. For example the following filter
will still install the root node even if it has an exclude all clause, right? I
tested and that is the case but wanted to confirm the intent.
{code}
<?xml version="1.0" encoding="UTF-8"?>
<workspaceFilter version="1.0">
<filter root="/tmp">
<exclude pattern=".*"/>
</filter>
</workspaceFilter>
{code}
was (Author: mpetria):
[~tripod] thanks for the fix. Just a clarifying question. It looks that
patterns only apply to subnodes of the root. For example the following filter
will still install the toot node even if it has an exclude all clause, right? I
tested and that is the case but wanted to confirm the intent.
{code}
<?xml version="1.0" encoding="UTF-8"?>
<workspaceFilter version="1.0">
<filter root="/tmp">
<exclude pattern=".*"/>
</filter>
</workspaceFilter>
{code}
> DefaultWorkspaceFilter.add(nodeFilters) does not include properties
> -------------------------------------------------------------------
>
> Key: JCRVLT-305
> URL: https://issues.apache.org/jira/browse/JCRVLT-305
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Reporter: Marius Petria
> Priority: Major
> Fix For: 3.2
>
>
> The add method should only add the filter set to nodeFilterSets, otherwise an
> include pattern for nodes will reject all properties.
> {code}
> public void add(PathFilterSet set) {
> nodesFilterSets.add(set);
> propsFilterSets.add(set);
> }
> {code}
> [1]
> https://github.com/apache/jackrabbit-filevault/blob/9eb53d36adfb7695a44075c72ca7ff0cedafabcc/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/DefaultWorkspaceFilter.java#L102
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
