[ https://issues.apache.org/jira/browse/JCRVLT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665267#comment-16665267 ]
Konrad Windszus edited comment on JCRVLT-320 at 10/26/18 3:06 PM: ------------------------------------------------------------------ PR with proposed fix: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/18 This still fails, as some ITs need to be adjusted due to a modified manifest being emitted from newer versions. The problem is that they by default include the Maven version (which is build-specific) in the header {{Created-By:Apache Maven 3.5.3}} and can therefore no longer reliably be checked in the IT. Although the code in https://github.com/apache/maven-archiver/blob/cba663c52d10644baa13fea06fc8b6c8469919e2/src/main/java/org/apache/maven/archiver/MavenArchiver.java#L656 is much older, it seems that the session was in older versions not available leading to only the entry {{Created-By:Apache Maven}} excluding the version information. Probably the {{ProjectBuilder.verifyExpectedManifest()}} needs to ignore this header. was (Author: kwin): PR with proposed fix: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/18 This still fails, as some ITs need to be adjusted due to a modified manifest being emitted from newer versions. The problem is that they by default include the Maven version (which is build-specific) in the header {{Created-By:Apache Maven 3.5.3}} and can therefore no longer reliably be checked in the IT > filevault-package-maven-plugin:package does not work with Java >= 10 > -------------------------------------------------------------------- > > Key: JCRVLT-320 > URL: https://issues.apache.org/jira/browse/JCRVLT-320 > Project: Jackrabbit FileVault > Issue Type: Bug > Affects Versions: package-maven-plugin-1.0.3 > Reporter: Konrad Windszus > Priority: Major > Fix For: package-maven-plugin-1.0.4 > > > When executing the goal {{package}} of {{filevault-package-maven-plugin}} > with Maven the following exception is thrown > {code} > [ERROR] Failed to execute goal > org.apache.jackrabbit:filevault-package-maven-plugin:1.0.3:package > (default-package) on project ...: Execution default-package of goal > org.apache.jackrabbit:filevault-package-maven-plugin:1.0.3:package failed: An > API incompatibility was encountered while executing > org.apache.jackrabbit:filevault-package-maven-plugin:1.0.3:package: > java.lang.ExceptionInInitializerError: null > [ERROR] ----------------------------------------------------- > .... > {code} > When executing with {{-X}} the following stacktrace is being exposed > {code} > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:181) > ... 21 more > Caused by: java.lang.ExceptionInInitializerError > at > org.apache.jackrabbit.filevault.maven.packaging.VaultMojo.execute(VaultMojo.java:192) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > ... 21 more > Caused by: java.lang.ArrayIndexOutOfBoundsException: 1 > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.<clinit>(AbstractZipArchiver.java:116) > ... 23 more > {code} > The reason for that is this line in {{plexus-archiver}} 2.9.1: > https://github.com/codehaus-plexus/plexus-archiver/blob/b6f3f79da02d5d238843038a774b8b2a313c8f2e/src/main/java/org/codehaus/plexus/archiver/zip/AbstractZipArchiver.java#L116 > This should be fixed in more recent versions: > https://github.com/codehaus-plexus/plexus-archiver/commit/c0357c5234fedb958bc2dd93a8397424bdcea7cf#diff-fc3ccce5d0e801c14a494428ab189152. -- This message was sent by Atlassian JIRA (v7.6.3#76005)