[
https://issues.apache.org/jira/browse/JCRVLT-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910563#comment-16910563
]
Konrad Windszus commented on JCRVLT-354:
----------------------------------------
I can not reproduce on Mac OS. I get the following only during {{mvn clean
package}}
{code}
[INFO] Scanning for projects...
[INFO]
[INFO] --<
mycompany.myprojectgroup:mycompany.myprojectgroup.myproject1.sample-content >--
[INFO] Building mycompany.myprojectgroup.myproject1.sample-content
1.0.0-SNAPSHOT
[INFO] --------------------------[ content-package ]---------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-clean) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] Deleting
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/target
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-default) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (warn-maven-eclipse-plugin) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (ban-maven-scr-plugin) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (ban-maven-sling-plugin) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (warn-maven-scr-annotations) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- buildnumber-maven-plugin:1.3:create (default) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] ShortRevision tag detected. The value is '8'.
[INFO] Executing: /bin/sh -c cd
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content
&& git rev-parse --verify --short=8 HEAD
[INFO] Working directory:
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content
[INFO] Storing buildNumber: ec0b5375 at timestamp: 2019-08-19 18:44:19
[INFO] Storing buildScmBranch: master
[INFO]
[INFO] --- buildnumber-maven-plugin:1.3:create-timestamp (default) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/src/main/resources
[INFO] skip non existing resourceDirectory
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/src/main/webapp
[INFO]
[INFO] --- sling-maven-plugin:2.4.2:validate (validate-json) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] No sources to compile
[INFO]
[INFO] --- htl-maven-plugin:1.2.4-1.4.0:validate (validate-scripts) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] Source directory does not exist, skipping.
[INFO]
[INFO] --- filevault-package-maven-plugin:1.0.4:check-signature
(default-check-signature) @ mycompany.myprojectgroup.myproject1.sample-content
---
[INFO] No signature defined. Skipping signature check.
[INFO]
[INFO] --- filevault-package-maven-plugin:1.0.4:analyze-classes
(default-analyze-classes) @ mycompany.myprojectgroup.myproject1.sample-content
---
[INFO] Analyzing java package dependencies.
[INFO] Export package report:
Exported packages Uses Version Dependency
----------------------------------------------------------------------
org.apache.sling.servlets.annotations 0 0.0.0
org.apache.sling:org.apache.sling.servlets.annotations:jar:1.2.4
org.osgi.annotation.versioning 0 1.1
org.osgi:org.osgi.annotation.versioning:jar:1.1.0
org.osgi.service.component.annotations 0 1.4.0
org.osgi:org.osgi.service.component.annotations:jar:1.4.0
org.osgi.service.metatype.annotations 0 1.4.0
org.osgi:org.osgi.service.metatype.annotations:jar:1.4.0
4 unused bundles
------------------------------
org.apache.sling:org.apache.sling.servlets.annotations:jar:1.2.4
org.osgi:org.osgi.annotation.versioning:jar:1.1.0
org.osgi:org.osgi.service.component.annotations:jar:1.4.0
org.osgi:org.osgi.service.metatype.annotations:jar:1.4.0
Packages used in the analyzed classes:
------------------------------
[INFO]
[INFO] --- filevault-package-maven-plugin:1.0.4:generate-metadata
(default-generate-metadata) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] using meta-inf/vault from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/META-INF/vault
[INFO] Loading filter from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/META-INF/vault/filter.xml
[INFO] Ignoring dependency validation due to non-application package type:
CONTENT
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] No tests to run.
[INFO]
[INFO] --- filevault-package-maven-plugin:1.0.4:package (default-package) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] using meta-inf/vault from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/META-INF/vault
[INFO] packaging content from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/jcr_root
[WARNING] File
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/jcr_root/.content.xml
not covered by a filter rule and therefore not contained in the resulting
package
[WARNING] File
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/jcr_root/content/.content.xml
not covered by a filter rule and therefore not contained in the resulting
package
[WARNING] File
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/jcr_root/content/dam/.content.xml
not covered by a filter rule and therefore not contained in the resulting
package
[INFO] Scanning files for oak index definitions.
[INFO] Building content-package:
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/target/myproject1-sample-content-1.0.0-SNAPSHOT.zip
[INFO]
[INFO] --- maven-source-plugin:3.1.0:jar-no-fork (attach-sources-no-fork) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] No sources in project. Archive not created.
[INFO]
[INFO] --- maven-javadoc-plugin:3.1.0:jar (attach-javadocs) @
mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] Not executing Javadoc as the project is not a Java classpath-capable
package
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.665 s
[INFO] Finished at: 2019-08-19T18:44:21+02:00
[INFO] ------------------------------------------------------------------------
{code}
with
{code}
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T21:00:29+02:00)
Maven home: /usr/local/Cellar/maven/3.6.1/libexec
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/jre
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"
{code}
So maybe indeed another Windows specific problem. In any case I think it would
be useful to distinguish ancestor nodes of covered nodes and completely
dangling ones. Maybe the first type should only lead to LOGs of type INFO.
> False warnings for files not being included in the package due to being
> outside of filter roots
> -----------------------------------------------------------------------------------------------
>
> Key: JCRVLT-354
> URL: https://issues.apache.org/jira/browse/JCRVLT-354
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
> Affects Versions: package-maven-plugin-1.0.4
> Reporter: Stefan Seifert
> Assignee: Konrad Windszus
> Priority: Major
>
> the new check introduced in JCRVLT-321 produces false warnings in my case -
> or i do not understand why the warning occurs.
> here is a sample project:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/sample-content
> i can understand these warnings
> {noformat}
> [WARNING] File content-packages\sample-content\jcr_root\.content.xml not
> covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\.content.xml not covered
> by a filter rule and therefore not contained in the resulting package
> {noformat}
> although it's a pity they are reported because usually these .content.xml
> files "above" the filter paths help creating in between nodes when the
> package is extracted and the parent paths of the filter do not exist yet.
> but i do not understand these warnings as the files are definitely included
> in the filter:
> {noformat}
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\myproject1\.content.xml not
> covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\myproject1\en\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
