kwin edited a comment on pull request #293:
URL: https://github.com/apache/jackrabbit-oak/pull/293#issuecomment-843834384
> does the session contain any modifications after the exception
Potentially yes, but that was the case before this patch as well.
> adding a {{assertFalse(session.hasPendingChanges()}} should be added to
the tests.
Not everything is reverted but just the conflicting node, so there might be
changes in the session up to the point where the exception was thrown. This is
IMHO expected behaviour.
> also i would like you to invite more oak-committers for the review as i am
not the owner of the importer code and might well miss some crucial pieces.
I would love to but that isn't possible due to
https://lists.apache.org/thread.html/rc57f0d58647113bad470d2632ec9cf3013ae3c6d41b759ada14c47be%40%3Cdev.jackrabbit.apache.org%3E.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
