tripodsan commented on a change in pull request #163: URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747246708
########## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java ########## @@ -1295,6 +1298,33 @@ public void endElement(String uri, String localName, String qName) throws SAXExc } } + private boolean hasSiblingWithSameType(Node child) throws RepositoryException { + + Node parent = child.getParent(); + + try { + EffectiveNodeType ent = EffectiveNodeType.ofNode(parent); + String typeName = ent.getApplicableChildNodeDefinition(child.getName(), child.getPrimaryNodeType()).get().getName(); + + NodeIterator iter = parent.getNodes(); + while (iter.hasNext()) { + Node sibling = iter.nextNode(); + if (!sibling.isSame(child)) { + Optional<NodeDefinition> childDef = ent.getApplicableChildNodeDefinition(sibling.getName(), + sibling.getPrimaryNodeType()); + try { + if (typeName.equals(childDef.get().getName())) { Review comment: but nt:file and nt:folder are not nt:resources.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org