reschke commented on a change in pull request #202:
URL:
https://github.com/apache/jackrabbit-filevault/pull/202#discussion_r786918756
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java
##########
@@ -386,6 +386,7 @@ private void extract(Set<PackageId> processed,
ImportOptions options, boolean cr
// MAX_VALUE disables saving completely, therefore we have to use
a lower value!
opts.setAutoSaveThreshold(Integer.MAX_VALUE - 1);
}
+ opts.setIdConflictPolicy(mgr.getDefaultIdConflictPolicy());
Review comment:
I tried to embed the logic in ImportOptions, and extended "toString()"
and friends accordingly. Now ExecutionPlanBuilderImplTest.testSaveAndLoad fails
- what do I need to adjust?
Current change:
https://gist.github.com/reschke/9c0dc1190d17758ae0ed50ebd89f37f2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
