[ 
https://issues.apache.org/jira/browse/JCRVLT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated JCRVLT-606:
-----------------------------------
    Description: 
In case the given {{VaultPackage}} returns {{null}} for its {{getFile()}} 
method, the following NPE is thrown:

{code}
java.lang.NullPointerException
        at java.util.zip.ZipFile.<init>(ZipFile.java:220)
        at java.util.zip.ZipFile.<init>(ZipFile.java:162)
        at 
org.apache.jackrabbit.vault.packaging.impl.PackageManagerImpl.rewrap(PackageManagerImpl.java:216)
        at 
org.apache.jackrabbit.vault.packaging.impl.PackageManagerImpl.rewrap(PackageManagerImpl.java:183)
        at ...
{code}

Instead of relying on implementation details of {{VaultPackage}} it should only 
act on {{Archive}} API to be able to rewrap arbitrary {{VaultPackage}} types.

  was:
In case the given {{VaultPackage}} returns {{null}} for its {{getFile()}} 
method, the following NPE is thrown:

{code}
java.lang.NullPointerException
        at java.util.zip.ZipFile.<init>(ZipFile.java:220)
        at java.util.zip.ZipFile.<init>(ZipFile.java:162)
        at 
org.apache.jackrabbit.vault.packaging.impl.PackageManagerImpl.rewrap(PackageManagerImpl.java:216)
        at 
org.apache.jackrabbit.vault.packaging.impl.PackageManagerImpl.rewrap(PackageManagerImpl.java:183)
        at ...
{code}


> Potential NPE in PackageManager.rewrap(....)
> --------------------------------------------
>
>                 Key: JCRVLT-606
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-606
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>    Affects Versions: 3.5.8
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: 3.6.0
>
>
> In case the given {{VaultPackage}} returns {{null}} for its {{getFile()}} 
> method, the following NPE is thrown:
> {code}
> java.lang.NullPointerException
>       at java.util.zip.ZipFile.<init>(ZipFile.java:220)
>       at java.util.zip.ZipFile.<init>(ZipFile.java:162)
>       at 
> org.apache.jackrabbit.vault.packaging.impl.PackageManagerImpl.rewrap(PackageManagerImpl.java:216)
>       at 
> org.apache.jackrabbit.vault.packaging.impl.PackageManagerImpl.rewrap(PackageManagerImpl.java:183)
>       at ...
> {code}
> Instead of relying on implementation details of {{VaultPackage}} it should 
> only act on {{Archive}} API to be able to rewrap arbitrary {{VaultPackage}} 
> types.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to