fabriziofortino commented on code in PR #552:
URL: https://github.com/apache/jackrabbit-oak/pull/552#discussion_r859555432
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexCleanerTest.java:
##########
@@ -75,9 +75,9 @@ public void testIndexDeletion() throws Exception {
assertTrue(exists(indexId3));
Thread.sleep(5000);
- cleaner.run();
assertEventually(() -> {
+ cleaner.run();
Review Comment:
moving the `run` inside the `assertEventually` block could result in
multiple `run` executions. Is this what we want?
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java:
##########
@@ -186,4 +263,37 @@ private void setUseDocker(boolean useDocker) {
public boolean useDocker() {
return useDocker;
}
+
+ public class ElasticConnectionConnectionModel {
Review Comment:
`Connection` appears twice
```suggestion
public class ElasticConnectionModel {
```
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java:
##########
@@ -130,6 +139,46 @@ private void
downloadSimilaritySearchPluginIfNotExists(String localPluginPath, S
}
}
+
+
+ private ElasticConnectionConnectionModel initializeElasticConnectionModel
(String elasticConnectionString) {
Review Comment:
this method and the overloaded version below initialize an instance
variable. The return values are never used. Should we remove them?
```suggestion
private void initializeElasticConnectionModel (String
elasticConnectionString) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
