stefan-egli commented on code in PR #560:
URL: https://github.com/apache/jackrabbit-oak/pull/560#discussion_r873962108
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeState.java:
##########
@@ -414,6 +414,11 @@ public String toString() {
* @param revision the revision this node is created.
*/
UpdateOp asOperation(@NotNull Revision revision) {
+
+ if (Utils.isNodeNameLong(path,
store.getDocumentStore().getNodeNameLimit())) {
+ throw new DocumentStoreException("Node name is too long: " + path);
+ }
+
Review Comment:
Good point, `UpdateOp` doesnt have the `path` .. and `asOperation` is used
as part of `addNode`, so it does make sense. I'm just wondering if that covers
100% of the cases.. hmm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
