rishabhdaim commented on PR #690: URL: https://github.com/apache/jackrabbit-oak/pull/690#issuecomment-1249557733
I think we discussed on these lines earlier to create a separate `StatsCollector` for throttling operation but It would essentially mean to duplicate the stats collection logic and its related APIs at 2 different places i.e. `DocumentStoreStatsCollector` & `ThrottlingStatsCollector`. The only thing we achieve from this is having 2 different `StatsCollectors` on basis of whether throttling is enabled or not. If we look closely, then these 2 classes are essentially the same barring the method to calculate the time taken to complete the operation and the actual metrics to store the stats (both of which can be parameterized). IMHO, the exiting APIs suit perfectly well for throttling after adding the time taken logic and throttling metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
