[ 
https://issues.apache.org/jira/browse/JCR-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740238#comment-17740238
 ] 

Manfred Baedke edited comment on JCR-4946 at 7/5/23 2:32 PM:
-------------------------------------------------------------

Patches for JCR-4570 and JCR-4571 should be applied first. Then we should 
decide if the tested behavior is correct at all, see OAK-10166. If it's not 
AbstractActiveLock#isLockedByToken(String) and IfHeaderEntryToken#match(String, 
String) have to be changed as indicated by the inline comments (kudos to 
balamir.ko...@gmail.com who pointed that out on oak-dev).


was (Author: baedke):
Patches for JCR-4570 and JCR-4571 should be applied first. Then we should 
decide if the tested behavior is correct at all, see OAK-10166. If it's not 
AbstractActiveLock#isLockedByToken(String) and IfHeaderEntryToken#match(String, 
String) have to be changed as indicated by the inline comments.

> Cleanup lock discovery and add test cases for the case sensitivity of lock 
> tokens
> ---------------------------------------------------------------------------------
>
>                 Key: JCR-4946
>                 URL: https://issues.apache.org/jira/browse/JCR-4946
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-webdav
>            Reporter: Manfred Baedke
>            Assignee: Manfred Baedke
>            Priority: Minor
>         Attachments: jcr-4946.patch
>
>
> The method ActiveLock#isLockedByToken(String lockToken) is implemented  at 
> several places, but only needs one implementation in AbstractActiveLock.
> Also, the case sensitivity of the lock token comparison is not tested .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to