mreutegg commented on code in PR #1011: URL: https://github.com/apache/jackrabbit-oak/pull/1011#discussion_r1304259012
########## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java: ########## @@ -1015,6 +1015,9 @@ public void checkPreconditions() throws RepositoryException { throw new VersionException(format( "Cannot add mixin type. Node [%s] is checked in.", getNodePath())); } + // OAK-10334: adding mixin requires permission to read existing mixin types + PropertyState prop = PropertyStates.createProperty(JCR_MIXINTYPES, singleton(oakTypeName), NAMES); + sessionContext.getAccessManager().checkPermissions(dlg.getTree(), prop, Permissions.READ_PROPERTY); Review Comment: Done. @anchela, please have a look at the changes again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org