nit0906 commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1343534093
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java:
##########
@@ -130,7 +131,7 @@ public class FlatFileNodeStoreBuilder {
private Predicate<String> pathPredicate = path -> true;
private final boolean compressionEnabled =
Boolean.parseBoolean(System.getProperty(OAK_INDEXER_USE_ZIP, "true"));
- private final boolean useLZ4 =
Boolean.parseBoolean(System.getProperty(OAK_INDEXER_USE_LZ4, "false"));
+ private final boolean useLZ4 =
Boolean.parseBoolean(System.getProperty(OAK_INDEXER_USE_LZ4,
DEFAULT_OAK_INDEXER_USE_LZ4));
private final Compression algorithm = compressionEnabled ? (useLZ4 ? new
LZ4Compression() : Compression.GZIP) :
Review Comment:
Should we move the logic to read the system prop for compression to some
util class - maybe IndexStoreUtils - assuming this would also be needed for the
TreeFS builder later on ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
