amit-jain commented on code in PR #1135:
URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1346787350
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java:
##########
@@ -410,11 +536,19 @@ public static File sortAndSave(List<String> tmplist,
* location of the temporary files (set to null for default
location)
* @param distinct
* Pass <code>true</code> if duplicate lines should be
discarded.
+ * @param filterPredicate
+ * predicate to filter out data which need to be sorted
*/
+ public static File sortAndSave(List<String> tmplist,
+ Comparator<String> cmp, Charset cs,
File tmpdirectory,
+ boolean distinct, boolean usegzip,
Predicate<String> filterPredicate) throws IOException {
+ return sortAndSave(tmplist, cmp, cs, tmpdirectory, distinct, usegzip,
identity(), filterPredicate);
+ }
+
public static File sortAndSave(List<String> tmplist,
Review Comment:
Not sure why this method uses List<String> and a couple others but all other
methods use List<T>. These methods may have been already available. I didn't
see any usage of these withink Oak. Maybe mark them deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
