nfsantos commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347125441
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreUtils.java:
##########
@@ -39,6 +40,23 @@
public class IndexStoreUtils {
public static final String METADATA_SUFFIX = ".metadata";
+ public static final String OAK_INDEXER_USE_ZIP = "oak.indexer.useZip";
+ public static final String OAK_INDEXER_USE_LZ4 = "oak.indexer.useLZ4";
+
+ public static boolean compressionEnabled() {
Review Comment:
Yes, I agree, it's not very clear. I would prefer to have a single property,
like: `oak.indexer.flatfilestore_compression = [none | gzip | lz4]`. But that
is a bigger change, as it would change the public API of this class, breaking
any clients that are relying on the current variable names. Probably it's worth
to do it to reduce technical debt sometime in the future, but we should not
piggy back it in an unrelated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
