stefan-egli commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1810151449
> it disables an optimization that avoids looking at split docs; so in the worst case, we'd see a performance degradation, right? right. * in most of the cases there wouldn't be any split documents anyway (in which cases this change is a virtual no-op) * in those cases where there are split document it would mostly not consider them neither as it `isMostRecentCommitted` would return true (in which case this change should not have any noticeable performance impact) * but in heavily updated nodes it would have an impact, yes. but that's also where the fix is needed. btw: it does follow the same logic as in `getNodeAtRevision` ([here](https://github.com/apache/jackrabbit-oak/blob/a5300d8088eacf7d5662ef5b8a7a64abad1ce7bf/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java#L969-L993)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
