thomasmueller commented on code in PR #1202:
URL: https://github.com/apache/jackrabbit-oak/pull/1202#discussion_r1393966334
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedSortBatchTask.java:
##########
@@ -116,48 +136,90 @@ public Result call() throws Exception {
}
}
+ private void buildSortArray(NodeStateEntryBatch nseb) {
+ Stopwatch startTime = Stopwatch.createStarted();
+ ByteBuffer buffer = nseb.getBuffer();
+ int totalPathSize = 0;
+ while (buffer.hasRemaining()) {
+ int positionInBuffer = buffer.position();
+ // Read the next key from the buffer
+ int pathLength = buffer.getInt();
+ totalPathSize += pathLength;
+ if (pathLength > copyBuffer.length) {
+ LOG.debug("Resizing copy buffer from {} to {}",
copyBuffer.length, pathLength);
+ copyBuffer = new byte[pathLength];
+ }
+ buffer.get(copyBuffer, 0, pathLength);
+ // Skip the json
+ int entryLength = buffer.getInt();
+ buffer.position(buffer.position() + entryLength);
+ // Create the sort key
+ String path = new String(copyBuffer, 0, pathLength,
StandardCharsets.UTF_8);
+ String[] pathSegments = SortKey.genSortKeyPathElements(path);
Review Comment:
Just an idea: if we don't need "path" and only the array, then maybe we
could store the number of entries and then the entries separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
