[ 
https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807689#comment-17807689
 ] 

Julian Reschke edited comment on JCRVLT-737 at 1/17/24 12:38 PM:
-----------------------------------------------------------------

As a next step, we could try the test and see whether it actually behaves 
differently under 3.5.0.

Output for  [^ReferenceableIdentifiersImportIT.java]:
{noformat}
[INFO] Running 
org.apache.jackrabbit.vault.packaging.integration.ReferenceableIdentifiersImportIT
13:35:10.463 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - repository created: 
Apache Jackrabbit Oak 1.38.0
13:35:11.375 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Collecting import 
information...
13:35:11.377 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Installing node 
types...
13:35:11.377 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Installing 
privileges...
13:35:11.377 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Importing content...
13:35:11.387 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /
13:35:11.389 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /testroot
13:35:11.392 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - 
/testroot/LEGACY-45674382171c.txt-renamed
13:35:11.392 [main] ERROR o.a.jackrabbit.vault.fs.io.Importer - E 
/testroot/LEGACY-45674382171c.txt/binary.txt (java.lang.IllegalStateException: 
Parent node not found.)
13:35:11.392 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - E 
/testroot/LEGACY-45674382171c.txt/binary.txt java.lang.IllegalStateException: 
Parent node not found.
13:35:11.392 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - saving approx 1 
nodes...
13:35:11.398 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Package imported 
(with errors, check logs!)
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.721 s 
- in 
org.apache.jackrabbit.vault.packaging.integration.ReferenceableIdentifiersImportIT
{noformat}

So LEGACY mode is indeed doing what 3.5.0 did.


was (Author: reschke):
As a next step, we could try the test and see whether it actually behaves 
differently under 3.5.0.

Output:
{noformat}
[INFO] Running 
org.apache.jackrabbit.vault.packaging.integration.ReferenceableIdentifiersImportIT
13:35:10.463 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - repository created: 
Apache Jackrabbit Oak 1.38.0
13:35:11.375 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Collecting import 
information...
13:35:11.377 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Installing node 
types...
13:35:11.377 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Installing 
privileges...
13:35:11.377 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Importing content...
13:35:11.387 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /
13:35:11.389 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - /testroot
13:35:11.392 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - - 
/testroot/LEGACY-45674382171c.txt-renamed
13:35:11.392 [main] ERROR o.a.jackrabbit.vault.fs.io.Importer - E 
/testroot/LEGACY-45674382171c.txt/binary.txt (java.lang.IllegalStateException: 
Parent node not found.)
13:35:11.392 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - E 
/testroot/LEGACY-45674382171c.txt/binary.txt java.lang.IllegalStateException: 
Parent node not found.
13:35:11.392 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - saving approx 1 
nodes...
13:35:11.398 [main] INFO  o.a.j.v.p.i.IntegrationTestBase - Package imported 
(with errors, check logs!)
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.721 s 
- in 
org.apache.jackrabbit.vault.packaging.integration.ReferenceableIdentifiersImportIT
{noformat}

So LEGACY mode is indeed doing what 3.5.0 did.

> Parent node not found when installing a package
> -----------------------------------------------
>
>                 Key: JCRVLT-737
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-737
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 3.7.2
>            Reporter: Timothee Maret
>            Priority: Major
>         Attachments: ReferenceableIdentifiersImportIT.java
>
>
> When importing a resource that already exists at with the same jcr:uuid but 
> at a different path, the importer balks with :
>  
> {code:java}
> Caused by: javax.jcr.RepositoryException: Some errors occurred while 
> installing packages. Please check the logs for details. First exception is 
> logged as cause.
>       at org.apache.jackrabbit.vault.fs.io.Importer.run(Importer.java:579) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.sling.distribution.serialization.impl.vlt.FileVaultContentSerializer.importFromStream(FileVaultContentSerializer.java:151)
>  [org.apache.sling.distribution.core:0.6.0.T202209271257-98a9dd5]
>       ... 11 common frames omitted
> Caused by: org.apache.jackrabbit.vault.packaging.PackageException: Error 
> creating/updating node 
> /content/dam/cgc/tenants/apac/documents/unitholder-letter/pds-cgnpau-12012023(au).pdf/jcr:content
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1177) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:976) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       at org.apache.jackrabbit.vault.fs.io.Importer.run(Importer.java:531) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       ... 12 common frames omitted
> Caused by: java.lang.IllegalStateException: Parent node not found.
>       at 
> org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1103) 
> [org.apache.jackrabbit.vault:3.7.1.T20231005151103-335689a8]
>       ... 23 common frames omitted  {code}
> After removing the resource from the target repository, re-applying the 
> package will succeed.
>  
> Configuration of the importer:
> {code:java}
> aclHandling :"MERGE_PRESERVE"
> cugHandling :"OVERWRITE"
> importMode: "REPLACE"
> autoSaveThreshold: 1000 {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to