nit0906 commented on code in PR #1276:
URL: https://github.com/apache/jackrabbit-oak/pull/1276#discussion_r1463008272
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResponseListener.java:
##########
@@ -68,8 +68,9 @@ default void startData(long totalHits) { /*empty*/ }
/**
* This method is called for each {@link Hit} retrieved
* @param searchHit a search result
+ * @return true if the search hit was successfully processed, false
otherwise
*/
- void on(Hit<ObjectNode> searchHit);
Review Comment:
This change atm might be considered a breaking change imo.
If we know for sure that this interface is not implemented outside oak, we
should probably mark it with @ProviderType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
