mbaedke commented on code in PR #1281:
URL: https://github.com/apache/jackrabbit-oak/pull/1281#discussion_r1463303254
##########
oak-core-spi/src/test/java/org/apache/jackrabbit/oak/namepath/PathParserTest.java:
##########
@@ -301,20 +300,21 @@ public void testUnexpectedOpeningSquareBracket() throws
RepositoryException {
path = "a[[";
listener = new TestListener(
+ CALLBACKRESULT_ERROR_ANY
//the parser actually produces an error, but we should change
the error message to something like this
- CALLBACKRESULT_ERROR(errorClosingQuareBracketExpected(path))
+ //CALLBACKRESULT_ERROR(errorClosingQuareBracketExpected(path))
);
verifyResult(path, listener, false);
}
@Test
- @Ignore //OAK-10611
public void testMissingClosingSquareBracket() throws RepositoryException {
String path = "/a[";
TestListener listener = new TestListener(
CALLBACKRESULT_ROOT,
+ CALLBACKRESULT_ERROR_ANY
//the parser actually produces an error, but we should change
the error message to something like this
- CALLBACKRESULT_ERROR(errorClosingQuareBracketExpected(path))
+ //CALLBACKRESULT_ERROR(errorClosingQuareBracketExpected(path))
Review Comment:
I cleaned up the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
