stefan-egli commented on code in PR #1287:
URL: https://github.com/apache/jackrabbit-oak/pull/1287#discussion_r1469642164
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -153,13 +153,14 @@ public class VersionGarbageCollector {
VersionGarbageCollector(DocumentNodeStore nodeStore,
VersionGCSupport gcSupport,
final boolean detailedGCEnabled,
- final boolean isDetailedGCDryRun) {
+ final boolean isDetailedGCDryRun,
+ final boolean embeddedVerification) {
this.nodeStore = nodeStore;
this.versionStore = gcSupport;
this.ds = gcSupport.getDocumentStore();
this.detailedGCEnabled = detailedGCEnabled;
this.isDetailedGCDryRun = isDetailedGCDryRun;
- this.embeddedVerification = true; //TODO: make this "configurable"
+ this.embeddedVerification = embeddedVerification; //TODO: make this
"configurable" for actual detailedGC
Review Comment:
detail: this TODO could now also move to DocumentNodeStore (assuming it will
have to be adjusted)
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -642,7 +642,7 @@ public DocumentNodeStore(DocumentNodeStoreBuilder<?>
builder) {
this.branches = new UnmergedBranches();
this.asyncDelay = builder.getAsyncDelay();
this.versionGarbageCollector = new VersionGarbageCollector(
- this, builder.createVersionGCSupport(),
isDetailedGCEnabled(builder), false);
+ this, builder.createVersionGCSupport(),
isDetailedGCEnabled(builder), false, false);
Review Comment:
Is there a particular reason for switching the default to `false`? I would
have preferred to keep it at `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
