ahanikel commented on PR #1296:
URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1945802627
@smiroslav If I understand correctly, while the segment containing the blob
reference is recovered, the file store tries to load that very segment uncached
and fails. Instead of creating a separate Map, can't we just put the recovered
segment in the segment cache, like this?
```modified
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/AbstractFileStore.java
@@ -233,6 +233,7 @@ public abstract class AbstractFileStore implements
SegmentStore, Closeable {
w.recoverEntry(msb, lsb, data, 0, data.length, generation);
if (SegmentId.isDataSegmentId(lsb)) {
Segment segment = new Segment(tracker, segmentReader,
tracker.newSegmentId(msb, lsb), buffer);
+ segmentCache.putSegment(segment);
populateTarGraph(segment, w);
populateTarBinaryReferences(segment, w);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
