stefan-egli commented on code in PR #1313:
URL: https://github.com/apache/jackrabbit-oak/pull/1313#discussion_r1497248562
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -2317,10 +2320,19 @@ private <T extends Document> DocumentStoreException
handleException(Throwable ex
invalidateCache(collection, id);
}
}
+
+ if (ex instanceof MongoWriteException) {
Review Comment:
Wondering if `MongoWriteException` is indeed the one we like to count.
Looking at the
[MongoServerException](https://mongodb.github.io/mongo-java-driver/3.12/javadoc/com/mongodb/MongoServerException.html)
it looks like there are bulk siblings that we might also be interested :
`BulkWriteException`, `MongoBulkWriteException` ?
If that's the case, then I'm wondering if we should count
`MongoServerException` instead - but arguably that's less specific than the
current `MongoWriteException` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
