reschke commented on code in PR #1314:
URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497847325


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java:
##########
@@ -274,6 +277,61 @@ private static String diagsForEntry(Map.Entry<String, 
PropertyStats> member) {
         }
     }
 
+    /**
+     * Produce an {@link UpdateOp} suitable for shrinking branch revision 
entries for given property in {@link Document}, {@code null} otherwise.
+     * 
+     * @param doc document to inspect for repeated branch commits
+     * @param propertName property to check for
+     * @param revisionChecker filter for revisions (for instance, to check for 
cluster id)
+     * @return {@link UpdateOp} suitable for shrinking document, {@code null} 
otherwise
+     */
+    public static @Nullable UpdateOp getShrinkOp(Document doc, String 
propertyName, Predicate<Revision> revisionChecker) {

Review Comment:
   I *think* we can do that once we use that from NodeDocumentStore, not 
DocumentStore...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to