nfsantos commented on code in PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1503753351
##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/FulltextIndexConstants.java:
##########
@@ -436,4 +437,12 @@ public static IndexingMode from(String indexingMode) {
* Boolean property indicating if in-built analyzer should preserve
original term
*/
String INDEX_ORIGINAL_TERM = "indexOriginalTerm";
+
+ /**
+ * Internal version of the index definition for specific index type. Index
version is an information that might be
+ * needed from an outside process that does not have visibility to the
specific index module.
+ */
+ Map<String, String> INDEX_VERSION_BY_TYPE = Map.of(
+ "elasticsearch", "1.1.0"
Review Comment:
Here we are using an hardcoded string, but there is already a constant
defined for this String in ElasticIndexDefinition. Since we are anyway exposing
in oak-search the index type of Elastic, I think it would be better to move
that constant somewhere to the oak-search module and use it here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
