stefan-egli commented on code in PR #1363:
URL: https://github.com/apache/jackrabbit-oak/pull/1363#discussion_r1521363291
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##########
@@ -352,7 +352,10 @@ private void applyToDocumentStore(RevisionVector
baseBranchRevision)
JournalEntry doc = JOURNAL.newDocument(store);
doc.modified(modifiedNodes);
Revision r = revision.asBranchRevision();
- store.create(JOURNAL, singletonList(doc.asUpdateOp(r)));
+ boolean success = store.create(JOURNAL,
singletonList(doc.asUpdateOp(r)));
+ if (!success) {
+ LOG.error("Failed to update journal for revision {}", r);
Review Comment:
Was wondering if we should also log the `doc` - it would contain the
modified paths (perhaps useful in analysing and presumably not leaking
sensitive information)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
