steffenvan commented on code in PR #1353:
URL: https://github.com/apache/jackrabbit-oak/pull/1353#discussion_r1521533757
##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextDocumentMaker.java:
##########
@@ -336,6 +339,37 @@ private boolean indexProperty(String path,
return dirty;
}
+ static String getValueAsTruncatedString(Object val) {
+ String value = val.toString();
+ boolean isArray = value.startsWith("[") && value.endsWith("]");
+ return value.length() <= LOG_TRUNCATION_LENGTH ? value
+ : value.substring(0, LOG_TRUNCATION_LENGTH) + "..." + (isArray ?
"]" : "");
+ }
+
+ static String truncateForLogging(PropertyState property) {
+ Type<?> t = property.getType();
+ if (t.isArray()) {
+ if (property.count() == 0) {
+ return "[]";
+ }
+
+ Type<?> base = t.getBaseType();
+ StringBuilder sb = new StringBuilder();
+ sb.append("[");
+ for (int i = 0; i < property.count(); i++) {
+ sb.append(property.getValue(base, i));
+ if (i < property.count() - 1) {
+ sb.append(", ");
+ }
+ }
+ sb.append("]");
Review Comment:
Yeah I like this better
##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextDocumentMaker.java:
##########
@@ -336,6 +339,37 @@ private boolean indexProperty(String path,
return dirty;
}
+ static String getValueAsTruncatedString(Object val) {
+ String value = val.toString();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
