rishabhdaim commented on PR #1367:
URL: https://github.com/apache/jackrabbit-oak/pull/1367#issuecomment-1998046586

   `the removal of the detailedGC / enable detailedGC (collect only) part`
   * This is done to avoid confusion since we have 2 ways to run detailedGC 
code i.e. from **_collect_** & **_detailedGC_** command. 
   
   `I was wondering how useful this new reset-after-full-repo-detailedGC`
   * I agree that this can be achieved by calling **_reset_** command, but 
having it inside the **_detailedGC_** command gives us one place/command to 
control everything around detailedGC. Also, it will save both the time & effort 
of a developer.
   
   `Otherwise just wondering if we should in the future aim to do general 
improvement of code`
   * I did it since it was only one-liner.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to