stefan-egli commented on code in PR #1417:
URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1567211982
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1993,17 +1996,18 @@ private boolean verifyViaTraversedState(NodeState
traversedState, NodeState trav
final Path path = newDoc.getPath();
final Revision lastRevision =
nodeStore.getPendingModifications().get(path);
if (traversedParent == null && !newDoc.getPath().isRoot()) {
- log.error("verify : no parent but not root for path : {}",
newDoc.getPath());
+ log.error("verify : no parent but not root for path : [{}]",
newDoc.getPath());
return false;
}
final RevisionVector lastRev;
if (traversedParent == null && newDoc.getPath().isRoot()) {
if (!(traversedState instanceof DocumentNodeState)) {
- log.error("verify : traversedState not a DocumentNodeState
: {}", traversedState.getClass());
+ log.error("verify : traversedState not a DocumentNodeState
: [{}]", traversedState.getClass());
return false;
}
lastRev = ((DocumentNodeState)
traversedState).getLastRevision();
} else {
+ // in case we are reaching here, it means that node is none of
parents are null
Review Comment:
(except in case of a verification error I guess?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
