rishabhdaim commented on code in PR #1426:
URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1586002212
##########
oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java:
##########
@@ -361,17 +364,32 @@ default boolean logWarningForPathFilterMismatch() {
* This method can be used for communicating any messages which should
be logged if this plan is selected for execution.
* The messages are returned as a map whose key indicates log level
and value is a list of messages against that
* log level.
+
+ * @deprecated use {@link #getAdditionalLogMessages()} instead
* @return map containing log messages.
*/
+ @Deprecated(forRemoval = true)
default Map<Level, List<String>> getAdditionalMessages() {
- return Collections.emptyMap();
+ LoggerFactory.getLogger(QueryIndex.IndexPlan.class).warn("use of
deprecated API - this method is going to be removed in future Oak releases -
see OAK-10768 for details");
Review Comment:
Shouldn't we add the name of the new API which is replacing it
##########
oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java:
##########
@@ -415,7 +433,33 @@ public Builder setDelayed(boolean isDelayed) {
return this;
}
+ /**
+ * @deprecated use {@link #addAdditionalMessage(String level,
String s)} instead
+ * */
+ @Deprecated(forRemoval = true)
public Builder addAdditionalMessage(Level level, String s) {
+ log.warn("use of deprecated API - this method is going to be
removed in future Oak releases - see OAK-10768 for details");
Review Comment:
same as above: we should add the name of the new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
