[
https://issues.apache.org/jira/browse/JCRVLT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844641#comment-17844641
]
Julian Reschke commented on JCRVLT-745:
---------------------------------------
[~joscorbe] - in theory this shouldn't be a problem if the nodes indeed were
temporary. What we found is that the stashing operation was failing due to a
combination of issues (Oak document store handling of ordered children, and
cleanup of intermediate commits). When it fails, it indeed leaves things where
they are, and I'm not sure it would be good if FV tried to handle that.
That said, I'm planning to make a PR that changes the order of locations where
the temp node creation is attempted (so "/" is last), and also improves naming
of these nodes (for more information should they stick).
> Stashing: naming and folder location
> ------------------------------------
>
> Key: JCRVLT-745
> URL: https://issues.apache.org/jira/browse/JCRVLT-745
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: vlt
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Major
>
> We have seen cases where node stashing failed due to RuntimeExceptions (OOM
> or MongoDB issues in Oak). In these cases, the tmp folder is not cleaned up.
> If the operation is retried many times, there'll be many of these.
> Suggestion:
> 1. Do not use the root as default location,
> 2. Introduce an intermediary node that makes it clear that this is temp space
> created by FileVault.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
