jsedding commented on PR #1371: URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2124026921
I read the spec on the subject of the `pid` in the `Designate` element and found that the `pid` attribute is ignored if a `factoryPid` attribute is present. Both, the `DefaultSyncHandler` and the `ExternalLoginModuleFactory` have the `factoryPid` attribute specified. Thus the new version is arguably more correct than the old version that includes the ignored `pid` attribute. > The [getPids()](https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.metatype.html#org.osgi.service.metatype.MetaTypeInformation.getPids--) method returns an array of PIDs that were specified in the pid attribute of the Object elements. The [getFactoryPids()](https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.metatype.html#org.osgi.service.metatype.MetaTypeInformation.getFactoryPids--) method returns an array of the factoryPid attributes. **For factories, the related pid attribute is ignored because all instances of a factory must share the same meta type.** (emphasis is mine) Source: https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.metatype.html#i1492258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
