Joscorbe commented on PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#issuecomment-2133548457
I'm fine with the tests, but both `stringBelowThresholdSize()` and `stringAboveThresholdSize()` are essentially the same - which is correct from a black box test point of view. However, I wonder if you could verify (with mockito for example) that the compressing/uncompressing was actually done in one of the tests and not in the other. Otherwise I feel these tests would pass even without using the new implemented code at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
