[ https://issues.apache.org/jira/browse/JCRVLT-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863822#comment-17863822 ]
Konrad Windszus edited comment on JCRVLT-760 at 7/8/24 4:10 PM: ---------------------------------------------------------------- The default source-release.zip is leveraging the config from asf parent POM: https://github.com/apache/maven-apache-parent/blob/67b9c7ea70fbe847116831c0a4bbcb8862f444b5/pom.xml#L434-L460 which relies on the assembly descriptor from https://github.com/apache/maven-apache-resources/tree/apache-resource-bundles-1.5/source-release That explicitly # excludes .asf.yaml (https://github.com/apache/maven-apache-resources/blob/f609acfd574277be6382ce381f65cab2db895d8d/source-release/src/main/resources/assemblies/source-shared.xml#L61) # adds DEPENDENCIES, LICENSE and NOTICE (https://github.com/apache/maven-apache-resources/blob/apache-resource-bundles-1.5/source-release/src/main/resources/assemblies/source-shared.xml#L78) with the content from https://github.com/apache/maven-apache-resources/tree/apache-resource-bundles-1.5/jar/src/main/resources/META-INF # incorrectly excludes {{min-target.bndrun}}, {{max-target.bndrun}} and {{target-osgi-environment}} due to https://github.com/apache/maven-apache-resources/blob/f609acfd574277be6382ce381f65cab2db895d8d/source-release/src/main/resources/assemblies/source-shared.xml#L30. This regex also covers any filenames containing {{target}}. I created https://issues.apache.org/jira/browse/MASFRES-69 to track that. was (Author: kwin): The default source-release.zip is leveraging the config from asf parent POM: https://github.com/apache/maven-apache-parent/blob/67b9c7ea70fbe847116831c0a4bbcb8862f444b5/pom.xml#L434-L460 which relies on the assembly descriptor from https://github.com/apache/maven-apache-resources/tree/apache-resource-bundles-1.5/source-release That explicitly # excludes .asf.yaml (https://github.com/apache/maven-apache-resources/blob/f609acfd574277be6382ce381f65cab2db895d8d/source-release/src/main/resources/assemblies/source-shared.xml#L61) # adds DEPENDENCIES, LICENSE and NOTICE (https://github.com/apache/maven-apache-resources/blob/apache-resource-bundles-1.5/source-release/src/main/resources/assemblies/source-shared.xml#L78) with the content from https://github.com/apache/maven-apache-resources/tree/apache-resource-bundles-1.5/jar/src/main/resources/META-INF # only considers sources from non POM modules (i.e. disregards https://github.com/apache/jackrabbit-filevault/tree/master/target-osgi-environment and both its children) # incorrectly excludes {{min-target.bndrun}} and {{max-target.bndrun}} due to https://github.com/apache/maven-apache-resources/blob/f609acfd574277be6382ce381f65cab2db895d8d/source-release/src/main/resources/assemblies/source-shared.xml#L30. This regex also covers any filenames containing {{target}}. I created https://issues.apache.org/jira/browse/MASFRES-69 to track that. > release check fails > ------------------- > > Key: JCRVLT-760 > URL: https://issues.apache.org/jira/browse/JCRVLT-760 > Project: Jackrabbit FileVault > Issue Type: Bug > Reporter: Julian Reschke > Assignee: Konrad Windszus > Priority: Minor > > As per https://jackrabbit.apache.org/filevault/howto_release.html I tried > {noformat} > sh check-release.sh filevault 3.7.4 > {noformat} > but that fails with: > {noformat} > [INFO] Unzipping jackrabbit-filevault-3.7.4-source-release.zip... > Cleaning .gitignore from zip > Cleaning .gitattributes from zip > Cleaning .flattened-pom.xml from zip > [INFO] Comparing sources... > [INFO] > Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4: > .asf.yaml > Only in ./target/jackrabbit-filevault-3.7.4/zip/jackrabbit-filevault-3.7.4: > DEPENDENCIES > Only in ./target/jackrabbit-filevault-3.7.4/zip/jackrabbit-filevault-3.7.4: > LICENSE > Only in ./target/jackrabbit-filevault-3.7.4/zip/jackrabbit-filevault-3.7.4: > NOTICE > Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4: > target-osgi-environment > Only in > ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-core: > max-target.bndrun > Only in > ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-core: > min-target.bndrun > Only in > ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-rcp: > max-target.bndrun > Only in > ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-rcp: > min-target.bndrun > Only in > ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-sync: > min-target.bndrun > Only in > ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-validation: > max-target.bndrun > Only in > ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-validation: > min-target.bndrun > [ERROR] NOT OK: Tagged sources are different from those in the archive > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)