kwin commented on code in PR #344: URL: https://github.com/apache/jackrabbit-filevault/pull/344#discussion_r1691737200
########## src/site/markdown/referenceablenodes.md: ########## @@ -21,7 +21,7 @@ ## Overview -The JCR 2.0 specification defines [referenceable nodes][1]. Those carry a `jcr:uuid` property which uniquely identifies a node within a repository workspace. Each FileVault export contains this (protected) property `jcr:uuid` as well which is important to keep [referential integrity][2]. +The JCR 2.0 specification defines [referenceable nodes][1]. Those carry a `jcr:uuid` property which uniquely identifies a node within a repository workspace. FileVault exports will contain this (protected) property `jcr:uuid` (when present) which is important to keep [referential integrity][2]. Review Comment: ```suggestion The JCR 2.0 specification defines [referenceable nodes][1]. Those carry a `jcr:uuid` property which uniquely identifies a node within a repository workspace. FileVault exports contain this (protected) property `jcr:uuid` (when present) which is important to keep [referential integrity][2]. ``` ########## src/site/markdown/referenceablenodes.md: ########## @@ -33,9 +33,11 @@ In case of conflicts among siblings the existing conflicting node is [removed][5 Since version 3.5.2 ([JCRVLT-551](https://issues.apache.org/jira/browse/JCRVLT-551)) FileVault tries to use the `jcr:uuid` of the node in the package even if a same named node does already exist. In case this cannot be achieved while keeping referential integrity of old and new nodes an exception is thrown. Existing nodes with conflicting identifiers or reference properties towards conflicting identifiers are removed in advance if they are contained in the [filter rules][4] to reduce the conflict potential. -### Id Conflict Policies +### Id Handling Policies -The import behavior of packages with conflicting ids can be tweaked with `ImportOptions.setIdConflictPolicy(...)` per package or the default can be overridden in the [OSGi Configuration](config.html). For further details refer to the [JavaDoc][3]. The old behavior can be achieved with `IdConflictPolicy.LEGACY`. +The import behavior of packages with can be tweaked with `ImportOptions.setIdConflictPolicy(...)` per package or the default can be overridden in the [OSGi Configuration](config.html). For further details refer to the [JavaDoc][3]. The old behavior can be achieved with `IdConflictPolicy.LEGACY`. + +Note that `CREATE_NEW_ID` will enforce creation of new identifiers, even when no node with conflicting ids. Review Comment: ```suggestion Note that `CREATE_NEW_ID` will enforce creation of new identifiers, even when no node with a conflicting id exists. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
