joerghoh commented on code in PR #376: URL: https://github.com/apache/jackrabbit-filevault/pull/376#discussion_r2218451901
########## vault-core/src/main/java/org/apache/jackrabbit/vault/util/EffectiveNodeType.java: ########## @@ -68,6 +71,8 @@ public final class EffectiveNodeType { private EffectiveNodeType(@NotNull List<NodeType> nodeTypes) { this.nodeTypes = nodeTypes; Review Comment: @kwin Thinking again: Let's leave it in. As mentioned ``toString`` still relies on it, and the cpu/memory overhead of having it is negligible. as these objects are typically very short-lived and are thus easily GCed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org