kwin commented on code in PR #383:
URL:
https://github.com/apache/jackrabbit-filevault/pull/383#discussion_r2325621668
##########
target-osgi-environment/min-target-osgi-environment/pom.xml:
##########
@@ -35,7 +35,7 @@
<description>The bndrun files referencing a repository index (containing
all bundles with their metadata) for resolving all FileVault bundles with
dependent bundles in their minimally required version</description>
<properties>
- <jackson.version>2.13.4</jackson.version>
+ <jackson.version>2.15.0</jackson.version>
Review Comment:
This environment used to reflect AEM 6.5.16. Please adjust all dependencies
to a real-world distribution version (not sure which AEM version ships with
jackson 2.15 and commons-io 2.14) and adjust the comment in line 41 accordingly.
##########
vault-rcp/pom.xml:
##########
@@ -206,7 +206,7 @@
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.api</artifactId>
Review Comment:
probably a candidate for dependency management in the parent as used more
than once.
##########
target-osgi-environment/max-target-osgi-environment/pom.xml:
##########
@@ -34,7 +34,7 @@
<description>The bndrun files referencing a repository index (containing
all bundles with their metadata) for resolving all FileVault bundles with
dependent bundles in their maximum supported version</description>
<properties>
- <jackson.version>2.13.4</jackson.version>
+ <jackson.version>2.14.0</jackson.version>
Review Comment:
let us adjust the dependencies to reflect the state in AEM 6.5 LTS SP1 or a
recent AEMaaCS (to check against a real world distribution).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
