kwin commented on code in PR #378:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/378#discussion_r2333858140


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/DefaultWorkspaceFilter.java:
##########
@@ -241,6 +241,10 @@ public void setSkipFilterChecksOnImport(boolean 
skipFilterChecksOnImport) {
         this.skipFilterChecksOnImport = skipFilterChecksOnImport;
     }
 
+    public boolean getSkipFilterChecksOnImport() {

Review Comment:
   But both FileArtifactHandler:accept and GenericArtifactHandler:accept have 
access to the ImportOptions which expose that already, so it needs to be passed 
along DocViewImporter, AbstractArtifactHandler:importDocView and 
FileArtifactHandler:importDocView which seems acceptable to me. Right now it 
really is duplicate in ImporterOptions and WorkspaceFilter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to