joerghoh commented on code in PR #384:
URL:
https://github.com/apache/jackrabbit-filevault/pull/384#discussion_r2339686478
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -1269,7 +1284,19 @@ private Node getNodeByIdOrName(@NotNull Node
currentNode, @NotNull DocViewNode2
return node;
}
- private boolean setUnprotectedProperties(@NotNull EffectiveNodeType
effectiveNodeType, @NotNull Node node, @NotNull DocViewNode2 ni, boolean
overwriteExistingProperties, @Nullable VersioningState vs) throws
RepositoryException {
+ /**
+ * Set all provided properties to the node.
+ * There is no check or special handling if the properties are protected
or not, so only invoke it with non-protected properties.
+ *
+ * @param node the node to set the properties to
+ * @param ni the DocViewNode to persist
+ * @param unprotectedProperties the unprotected properties to set on the
given node
+ * @param overwriteExistingProperties
+ * @param vs
+ * @return
+ * @throws RepositoryException
+ */
+ private boolean setUnprotectedProperties(@NotNull Node node, @NotNull
DocViewNode2 ni, @NotNull Collection<DocViewProperty2> unprotectedProperties,
boolean overwriteExistingProperties, @Nullable VersioningState vs) throws
RepositoryException {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
