[ 
https://issues.apache.org/jira/browse/JCR-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059345#comment-18059345
 ] 

Julian Reschke commented on JCR-5207:
-------------------------------------

{code}
Error:  
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest.testConcurrentLogin
 -- Time elapsed: 5.447 s <<< ERROR!
java.lang.IllegalStateException: Thread Thread-303 (id 926) failed
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest.lambda$assertThreadExecutionSucceeds$0(TokenBasedLoginTest.java:400)
        at java.base/java.util.Optional.map(Optional.java:265)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest.assertThreadExecutionSucceeds(TokenBasedLoginTest.java:400)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest.assertParallelExecutionSucceeds(TokenBasedLoginTest.java:374)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest.testConcurrentLogin(TokenBasedLoginTest.java:239)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at junit.framework.TestCase.runTest(TestCase.java:177)
        at junit.framework.TestCase.runBare(TestCase.java:142)
        at junit.framework.TestResult$1.protect(TestResult.java:122)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.framework.TestResult.run(TestResult.java:125)
        at org.apache.jackrabbit.test.JCRTestResult.run(JCRTestResult.java:75)
        at junit.framework.TestCase.run(TestCase.java:130)
        at 
org.apache.jackrabbit.test.AbstractJCRTest.run(AbstractJCRTest.java:475)
        at junit.framework.TestSuite.runTest(TestSuite.java:241)
        at junit.framework.TestSuite.run(TestSuite.java:236)
        at junit.framework.TestSuite.runTest(TestSuite.java:241)
        at junit.framework.TestSuite.run(TestSuite.java:236)
        at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
        at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
        at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
        at 
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
        at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
Caused by: 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest$UncheckedRepositoryException:
 javax.jcr.LoginException: Failed to commit: failed to build path of 
bf6cfd92-d111-4dd6-9520-0edec578bb93: c78639c8-7277-426b-9fde-1de145569d94 has 
no child entry for bf6cfd92-d111-4dd6-9520-0edec578bb93
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest$4.run(TokenBasedLoginTest.java:369)
        at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: javax.jcr.LoginException: Failed to commit: failed to build path of 
bf6cfd92-d111-4dd6-9520-0edec578bb93: c78639c8-7277-426b-9fde-1de145569d94 has 
no child entry for bf6cfd92-d111-4dd6-9520-0edec578bb93
        at 
org.apache.jackrabbit.core.RepositoryImpl.login(RepositoryImpl.java:1526)
        at 
org.apache.jackrabbit.commons.AbstractRepository.login(AbstractRepository.java:144)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest$1.run(TokenBasedLoginTest.java:245)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedLoginTest$4.run(TokenBasedLoginTest.java:367)
        ... 1 more
Caused by: javax.security.auth.login.LoginException: Failed to commit: failed 
to build path of bf6cfd92-d111-4dd6-9520-0edec578bb93: 
c78639c8-7277-426b-9fde-1de145569d94 has no child entry for 
bf6cfd92-d111-4dd6-9520-0edec578bb93
        at 
org.apache.jackrabbit.core.security.authentication.DefaultLoginModule.commit(DefaultLoginModule.java:114)
        at 
org.apache.jackrabbit.core.security.authentication.LocalAuthContext.login(LocalAuthContext.java:86)
        at 
org.apache.jackrabbit.core.RepositoryImpl.login(RepositoryImpl.java:1498)
        ... 4 more
Caused by: javax.jcr.ItemNotFoundException: failed to build path of 
bf6cfd92-d111-4dd6-9520-0edec578bb93: c78639c8-7277-426b-9fde-1de145569d94 has 
no child entry for bf6cfd92-d111-4dd6-9520-0edec578bb93
        at 
org.apache.jackrabbit.core.HierarchyManagerImpl.buildPath(HierarchyManagerImpl.java:298)
        at 
org.apache.jackrabbit.core.CachingHierarchyManager.buildPath(CachingHierarchyManager.java:233)
        at 
org.apache.jackrabbit.core.HierarchyManagerImpl.getPath(HierarchyManagerImpl.java:402)
        at 
org.apache.jackrabbit.core.CachingHierarchyManager.getPath(CachingHierarchyManager.java:267)
        at org.apache.jackrabbit.core.ItemImpl.getPrimaryPath(ItemImpl.java:188)
        at 
org.apache.jackrabbit.core.NodeImpl.getPrimaryPath(NodeImpl.java:2811)
        at 
org.apache.jackrabbit.core.ProtectedItemModifier.checkPermission(ProtectedItemModifier.java:175)
        at 
org.apache.jackrabbit.core.ProtectedItemModifier.setProperty(ProtectedItemModifier.java:108)
        at 
org.apache.jackrabbit.core.ProtectedItemModifier.setProperty(ProtectedItemModifier.java:103)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenProvider.createToken(TokenProvider.java:164)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenProvider.createToken(TokenProvider.java:125)
        at 
org.apache.jackrabbit.core.security.authentication.token.TokenBasedAuthentication.createToken(TokenBasedAuthentication.java:184)
        at 
org.apache.jackrabbit.core.security.authentication.DefaultLoginModule.commit(DefaultLoginModule.java:109)
        ... 6 more
{code}

(In Github CI)

> Deprecate TransientFileFactory (also add test hook)
> ---------------------------------------------------
>
>                 Key: JCR-5207
>                 URL: https://issues.apache.org/jira/browse/JCR-5207
>             Project: Jackrabbit Content Repository
>          Issue Type: Task
>          Components: jackrabbit-jcr-commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>
> - it depends on GC and/or shutdown hooks and thus is not predictable
> - it still potentially leaks files
> - it hides coding errors
> - code that relies on files not being removed may break when the cleanup 
> actually runs early



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to