reschke commented on code in PR #417:
URL:
https://github.com/apache/jackrabbit-filevault/pull/417#discussion_r3153183920
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/InstallHookProcessorImpl.java:
##########
@@ -117,14 +124,13 @@ public void registerHook(VaultInputSource input,
ClassLoader classLoader) throws
}
throw e;
}
- initHook(hook);
+ initHook(hook, null);
}
- private void initHook(Hook hook) throws IOException, PackageException {
+ private void initHook(Hook hook, PackageId packageId) throws IOException,
PackageException {
try {
- hook.init();
+ hook.init(packageId);
} catch (IOException | PackageException e) {
- log.error("Error while initializing hook: {}", e.toString());
Review Comment:
intentional to loose that logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
